reexport commonly used array/view packages #164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- IndirectArrays - MappedArrays - OffsetArrays - TiledIteration
johnnychen94
force-pushed
the
jc/reexport
branch
from
222d698
to
34ea3d6
Compare
Codecov Report
@@ Coverage Diff @@
## master #164 +/- ##
=======================================
Coverage 66.42% 66.42%
=======================================
Files 10 10
Lines 563 563
=======================================
Hits 374 374
Misses 189 189
Continue to review full report at Codecov.
|
|
Since ColorVectorSpace 0.9 brings many new symbols, we might also want to reexport that, too. |
|
FWIW I'm fine with this change if you want it (I haven't checked the costs myself). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Four packages are reexported by ImageCore:
The extra time overhead seems good to me. (Although in static compiled languages like C++ there's so-called best practice -- "what you don’t use, you don’t pay for", in Julia we still don't have a good solution for this, hence we need to make a tradeoff between the maintenance and overhead)